Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation mistake in StandardBullhornData.java #239

Open
joncampbelldev opened this issue Oct 8, 2018 · 0 comments
Open

Implementation mistake in StandardBullhornData.java #239

joncampbelldev opened this issue Oct 8, 2018 · 0 comments

Comments

@joncampbelldev
Copy link
Contributor

In the handleHttpStatusCodeError method, when it throws a RestApiException there are no parentheses around the ternary conditional error == null ? "" : error.getResponseBodyAsString().

This means that the error object is concatenated onto the preceding exception message before it is compared to null. The effect of which is that the exception message will always and only contain the response body string, never the uri variables or http status code.

Source of method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant