Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] "On Retry" is > 0. But where are we retrying those tests? #236

Open
jonathanyeong opened this issue Dec 10, 2024 · 1 comment

Comments

@jonathanyeong
Copy link

jonathanyeong commented Dec 10, 2024

Hey team, we migrated to using the new bktec (from v0.8.0!) and enjoying the extra observability so far. I had a question around "On retry". I see on retry greater then 0, but I don't see bktec actually retrying the test. Am I understanding this value correctly?

SCR-20241210-jxkb

If we compare to an actual failing test, I can see that bktec shows the retries
SCR-20241210-jwza

For context, migrating from 0.8.0 has resulted in test times that are overall a minute or two slower. So I wonder if that's the retry mechanism doing its thing.

@nprizal
Copy link
Contributor

nprizal commented Dec 10, 2024

Hey @jonathanyeong, thanks for reaching out. We’re facing a similar issue in Buildkite. It turns out that there are a few tests that share the same description. bktec and Test Engine use the combination of scope (example group description in Rspec) and name (example description in Rspec) to identify tests. If there are tests with the same scope and name, bktec reports them as passed on retry because it mistakenly believes that the “same” test has already been run.

We’re investigating this issue and will see if we can find a solution. In the meantime, could you please check if all test descriptions are unique? If you’re using RSpec (and Rubocop), you can use RSpec/RepeatedDescription and RSpec/RepeatedExampleGroupDescription to check for duplicates.

As for the test getting slower, there could be several factors contributing to this. Retry is one of them. I wouldn’t expect upgrading from 0.8.0 to 1.2.0 to slow down your test suites. To confirm if the test suite is indeed getting slower, you can check your test runs from the Test Splitting page in your Buildkite Test Suite. You can also look into individual runs to see the impact of job retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants