Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buf to version with protovalidate linter #15

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

pkwarren
Copy link
Member

@pkwarren pkwarren commented Nov 3, 2023

No description provided.

@pkwarren pkwarren marked this pull request as ready for review November 3, 2023 16:41
@pkwarren pkwarren requested a review from bufdev as a code owner November 3, 2023 16:41
@@ -10,7 +10,7 @@ BIN := .tmp/bin
export PATH := $(BIN):$(PATH)
export GOBIN := $(abspath $(BIN))

BUF_VERSION := v1.27.1
BUF_VERSION := 21ba19590be4afe6fa3af0406e138c4fdc36fedf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change to a new version when the new CLI release is available.

Copy link
Member

@jchadwick-buf jchadwick-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me. The actual validation rules will need to be updated still to match whatever range of length we actually want. (e.g. minimum for owner name may be >1) but that's not fully hashed out atm.

@pkwarren pkwarren merged commit d8fae8f into main Nov 3, 2023
5 checks passed
@pkwarren pkwarren deleted the pkw/protovalidate-linter branch November 3, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants