Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix *_id fields to use uuid validator #12

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

jchadwick-buf
Copy link
Member

@jchadwick-buf jchadwick-buf commented Oct 31, 2023

All fields that end in _id except spdx_license_id are UUIDs to my knowledge and should use string.uuid instead of string.max_len for validation.

@jchadwick-buf jchadwick-buf requested a review from bufdev as a code owner October 31, 2023 17:46
@jchadwick-buf jchadwick-buf merged commit 8b3f3b5 into main Oct 31, 2023
6 checks passed
@jchadwick-buf jchadwick-buf deleted the jchadwick/id-uuid branch October 31, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants