Handle validation error message for zero value for certain rules as a special case #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufdev
reviewed
Nov 18, 2023
| }, | ||
| (priv.field).cel = { | ||
| id: "string.hostname_empty", | ||
| message: "an empty value is not a valid hostname", |
There was a problem hiding this comment.
This is more a statement, it makes me ask the question "...ok, was my value empty?" I'd say something like "value was empty, and empty is not a valid X"
There was a problem hiding this comment.
updated in 23bed22, which now reads "value is empty, which is not a valid X"
oliversun9
commented
Nov 20, 2023
rodaine
approved these changes
Nov 20, 2023
emcfarlane
approved these changes
Dec 7, 2023
emcfarlane
reviewed
Dec 7, 2023
rodaine
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some string/bytes rules, if the string/bytes value is empty, we show a slightly different validation error message indicating the value is empty.