-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BP-3655 Apple Pay functionality #29
Comments
Goodmorning @elzekool , Thank you for contacting us about this issue. We'll take a look at this Just to be sure, did you also register the domain in the Buckaroo Plaza as well? |
Hey @Buckaroo-Rene , Yes, that is configured. Not entirely sure how it works between Buckaroo and Apple but I imagine that Buckaroo configures a merchant with Apple Pay with the Buckaroo GUID. At least that what I think is happening in the regular Magento 2 module at https://github.com/buckaroo-it/Magento2/blob/master/view/frontend/web/js/view/checkout/applepay/pay.js#L69, there |
any update on this? @elzekool did you manage to create a solution? We also encounter the same issue with the buttons on top of eachother |
@sanderjongsma / @elzekool we are looking into a solution for this. |
For one of our clients we want to implement Apple Pay however we noticed that the implementation had some issues. I am wondering if this is something that is known and on the radar to fix.
One issue we found during debugging is that in the method
register()
the method checkPaySupport() is called without a merchan tIdentifier (https://github.com/buckaroo-it/Magento2_Hyva_Checkout/blob/master/view/frontend/templates/component/payment/after.phtml#L262) while the original method defined in https://github.com/buckaroo-it/Magento2_Hyva_Checkout/blob/master/view/frontend/web/js/applepay.js#L15 requires it. This is an issue we could fix with providing this.config.guid to the BuckarooApplePay.checkPaySupport() method.However that leaded to a situation where there first appears an unstyled payment link ("Plaats bestelling" = "Place order" in Dutch):
And only after clicking that an Apple Pay button appears which also has a broken styling:
Our expectations were that the customer selects Apple Pay and then continue placing the order and if Apple Pay is not supported the method is not visible. Currently two situations happen:
Apple Pay is not supported or no active card: Nothing appears on the screen indicating this, the payment method is shown and the user receives a message "Payment data is missing" which seems to be triggerd in https://github.com/buckaroo-it/Magento2_Hyva_Checkout/blob/master/Magewire/Payment/Method/Applepay.php#L94
Apple Pay is supported, the customer then first needs to click the unstyled link and then the Apple Pay link and only then can place the order.
The text was updated successfully, but these errors were encountered: