Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-3843 v1.50+ breaks Magento API schema #1072

Open
MatthijsBreed opened this issue Oct 15, 2024 · 2 comments · Fixed by #1075
Open

BP-3843 v1.50+ breaks Magento API schema #1072

MatthijsBreed opened this issue Oct 15, 2024 · 2 comments · Fixed by #1075
Assignees
Labels
Bug Bugs, functions that are not working like they should. Priority: Normal This issue has a normal/medium priority. Status: Waiting for release This issue has been solved, but is not released yet.

Comments

@MatthijsBreed
Copy link

On version v1.50

When requesting api schema via <base_url>/rest/all/schema?services=all
Magento returns the following error The "QuoteCreateResponseInterface" class doesn't exist and the namespace must be specified. Verify and try again.

This is because Magento needs fully namespaced interfaces for the return types of interface functions used by webapi

This patch fixes the errors:

diff --git a/vendor/buckaroo/magento2/Api/IdealQuoteCreateInterface.php b/vendor/buckaroo/magento2/Api/IdealQuoteCreateInterface.php
--- a/vendor/buckaroo/magento2/Api/IdealQuoteCreateInterface.php	
+++ b/vendor/buckaroo/magento2/Api/IdealQuoteCreateInterface.php	(date 1728984361036)
@@ -31,7 +31,7 @@
      *
      * @param string $page
      * @param string|null $order_data
-     * @return QuoteCreateResponseInterface
+     * @return \Buckaroo\Magento2\Api\Data\QuoteCreateResponseInterface
      */
     public function execute(
         string $page,
diff --git a/vendor/buckaroo/magento2/Api/PaypalExpressQuoteCreateInterface.php b/vendor/buckaroo/magento2/Api/PaypalExpressQuoteCreateInterface.php
--- a/vendor/buckaroo/magento2/Api/PaypalExpressQuoteCreateInterface.php	
+++ b/vendor/buckaroo/magento2/Api/PaypalExpressQuoteCreateInterface.php	(date 1728984654773)
@@ -32,7 +32,7 @@
    * @param \Buckaroo\Magento2\Api\Data\PaypalExpress\ShippingAddressRequestInterface $shipping_address
    * @param string $page
    * @param string|null $order_data
-   * @return QuoteCreateResponseInterface
+   * @return \Buckaroo\Magento2\Api\Data\QuoteCreateResponseInterface
  */
   public function execute(
     ShippingAddressRequestInterface $shipping_address,
@Buckaroo-Rene Buckaroo-Rene changed the title v1.50+ breaks Magento api schema BP-3843 v1.50+ breaks Magento api schema Oct 18, 2024
@Buckaroo-Rene Buckaroo-Rene changed the title BP-3843 v1.50+ breaks Magento api schema BP-3843 v1.50+ breaks Magento API schema Oct 18, 2024
@Buckaroo-Rene Buckaroo-Rene self-assigned this Oct 18, 2024
@Buckaroo-Rene Buckaroo-Rene added Bug Bugs, functions that are not working like they should. Status: In progress We are working on this issue. Priority: Normal This issue has a normal/medium priority. labels Oct 18, 2024
@Buckaroo-Rene
Copy link
Contributor

Hi @MatthijsBreed ,

Thank you for bringing this issue to our attention.
We're currently investigating it and will keep you updated with any progress or resolutions.

Best regards,
René

@Buckaroo-Rene Buckaroo-Rene linked a pull request Oct 21, 2024 that will close this issue
@Buckaroo-Rene Buckaroo-Rene added Status: Waiting for release This issue has been solved, but is not released yet. and removed Status: In progress We are working on this issue. labels Oct 21, 2024
@Buckaroo-Rene
Copy link
Contributor

Hi @MatthijsBreed ,

@vegimcarkaxhija created a fix for this issue. it will be included in the next upcoming release will let you know when there is more information regarding the actual release date.

You can check out his commit right here: 9256d07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs, functions that are not working like they should. Priority: Normal This issue has a normal/medium priority. Status: Waiting for release This issue has been solved, but is not released yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants