Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance on running tests #48

Open
timvandenhof opened this issue Jul 22, 2021 · 0 comments
Open

Provide guidance on running tests #48

timvandenhof opened this issue Jul 22, 2021 · 0 comments

Comments

@timvandenhof
Copy link

timvandenhof commented Jul 22, 2021

The test project contains many tests, which don't run after checking out the repository.

As these are complete system integration tests which include the communication with the Buckaroo SDK and opening browsers and what not, please provide guidance on how to set up the environment to run te test so other might be able to contribute to this SDK. Same for TestSettings.cs which is intentionally left outside the repository as it might contain sensitive data. We have better options for that these days, so we might be able to improve that.

To improve this I would like to suggest:

  • Adding a contributing readme file
  • A description on how to run tests and/or set up environment
  • Improve credential management for running tests, by using something like UserSecrets
  • Improve test scenarios with asserts in stead of having to manually check variables after running a test (which case an IDE message as well: IDE0059 Unnecessary assignment of a value to '{variable}'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant