Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Add a hamburger which shows Admin Sidepanel on clicking #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ui): Add a hamburger which shows Admin Sidepanel on clicking #86

wants to merge 1 commit into from

Conversation

shounakpatil
Copy link

Overview

  1. This PR fixes or fixes part of Add Hamburger Menu for AdminPanel Sidebar on Mobile Devices. #85 .
  2. This PR does the following: [Explain here what your PR does and why]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

proof_vid.mp4
  1. Imported MenuIcon and SideDrawer components from the Material-UI library.
  2. Utilized React state management to toggle the side drawer.
  3. Configured the default variant of the sidebar to be displayed on mobile devices.

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

@vercel Vercel
Copy link

vercel bot commented Jun 7, 2024

@shounakpatil is attempting to deploy a commit to the Busify Team on Vercel.

A member of the Team first needs to authorize it.

@Pratik2026 Pratik2026 self-requested a review June 9, 2024 07:35
@Pratik2026 Pratik2026 linked an issue Jun 9, 2024 that may be closed by this pull request
Add Hamburger Menu for AdminPanel Sidebar on Mobile Devices. #85
Open
@Pratik2026
Copy link
Collaborator

@shounakpatil, the dashboard should not be inside a drawer in table & laptop screen. It should appear the same as it was before. Your changes should not affect the other screen layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratik2026 Pratik2026 Awaiting requested review from Pratik2026

Assignees

@shounakpatil shounakpatil

Labels
BSoC'24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Hamburger Menu for AdminPanel Sidebar on Mobile Devices.
3 participants
@shounakpatil @Pratik2026 @RISHIKESHk07