Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA example of tensor network contraction #154

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

Todorbsc
Copy link
Contributor

No description provided.

@mofeing
Copy link
Member

mofeing commented Jun 18, 2024

@Todorbsc only one thing, the

@benchmark CUDA.@sync contract(tn; path)

doesn't need the CUDA.@sync.

Everything else is fine.

Copy link
Member

@jofrevalles jofrevalles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Todorbsc
Copy link
Contributor Author

Done! If everything's fine now, feel free to merge it.

@mofeing
Copy link
Member

mofeing commented Jun 19, 2024

@Todorbsc you need to add the packages to the Project.toml inside examples/

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.07%. Comparing base (5ee9b93) to head (4be25b7).
Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #154       +/-   ##
===========================================
- Coverage   68.76%   51.07%   -17.69%     
===========================================
  Files          19       19               
  Lines        1050     1065       +15     
===========================================
- Hits          722      544      -178     
- Misses        328      521      +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing mofeing merged commit e46679b into master Jun 19, 2024
7 of 8 checks passed
@mofeing mofeing deleted the example/cuda-tn-contraction branch June 19, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants