fix Array-TracedRArray contraction and force dense representation of Yao gates
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
commented
Nov 26, 2024
jofrevalles
reviewed
Nov 26, 2024
not right now because we are on a rush and we also need to create the infrastructure for Reactant tests (there are no tests with Reactant here) #245 tracks that issue |
mofeing
changed the title
ControlBlock to Quantum conversionArray-TracedRArray contraction and force dense representation of Yao gates
jofrevalles
approved these changes
Nov 27, 2024
jofrevalles
pushed a commit
that referenced
this pull request
Dec 2, 2024
… of Yao gates (#258) * try fix reordering of sites * try fix layout of multi-qubit gates in Yao to Tenet conversion * Remove permutedims & add collect for array building * minor fixes on Reactant pkg extension * implement `copy` for some structs * fix column- to row-major layout conversion on `Reactant.promote_to` call * remove dead code --------- Co-authored-by: Todorbsc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Todorbsc