Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatch canonize! based on form #239

Open
mofeing opened this issue Nov 11, 2024 · 0 comments
Open

Dispatch canonize! based on form #239

mofeing opened this issue Nov 11, 2024 · 0 comments
Labels
good first issue Good for newcomers performance Makes the code go "brrrr"

Comments

@mofeing
Copy link
Member

mofeing commented Nov 11, 2024 •
edited
Loading

Currently canonize! on AbstractMPO just performs the whole canonization procedure, but the performance can be improved by a lot if we dispatch based on form, since Canonical wouldn't need to do anything and probably we can save some operations if starting from MixedCanonical.
@mofeing mofeing added the performance Makes the code go "brrrr" label Nov 11, 2024
@mofeing mofeing mentioned this issue Nov 11, 2024
Merged
@mofeing mofeing added the good first issue Good for newcomers label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers performance Makes the code go "brrrr"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mofeing