Visualize AbstractTensorNetworks interactively with ECharts
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jofrevalles
reviewed
Sep 25, 2024
| @@ -7,7 +7,9 @@ version = "0.8.0-DEV" | |||
| AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c" | |||
| Combinatorics = "861a8166-3701-5b0c-9a16-15d98fcdc6aa" | |||
| DeltaArrays = "10b0fc19-5ccc-4427-889b-d75dd6306188" | |||
| ECharts_jll = "ffd69456-1935-58d2-abba-ba12e8909167" | |||
There was a problem hiding this comment.
Shouldn't this be an extension? Since we have the visualization libraries GraphMakie and Makie as an extension too.
There was a problem hiding this comment.
I see your point but in this case no. The reason is that package extensions are there to avoid precompile and load time overheads.
In this case, ECharts is a JavaScript library (so only gets loaded on the web browser/notebook/VSCode, it doesn't get loaded to the Julia session). Furthermore, JLL packages don't load anything to memory... they are just wrappers over some "binary" files stored on disk. And the minified file just weights 1MiB...
|
closed in favor of #261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do
drawfunction (just likequimb)tenet-echarts.mp4