Concretize Ansatz type with "lattice"/connectivity information and refactor subtypes on top of it
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
requested review from
jofrevalles,
arturgs,
starsfordummies and
Todorbsc
mofeing
added
refactor
mofeing
force-pushed
the
refactor/ansatz-lattice
branch
4 times, most recently
from
678c3af
to
9b22b13
Compare
I wouldn't change the indices for plotting because it will lie to the users. |
I mean, you can take any |
…PS`, `MPO`, `PEPS`
…nsors) (#218) * Format code * Implement MPS identity initialization * Add tests for all dispatches of MPS identity init * Format julia code * Rename function header & add docstring * Fix test set for identity MPS * Format code * Rewrite MPS identity init function to nsites instead of arrays' dimensions * Format julia code * Update docstring of identity * Clean code in test (suggested by Jofre) Co-authored-by: Jofre Vallès Muns <[email protected]> * Format julia code * Refactor virtualdims in identity (suggested by Sergio) * Update src/Ansatz/MPS.jl * Restrict to default order in identity MPS * Update src/Ansatz/MPS.jl * Remove order parameter in identity --------- Co-authored-by: Jofre Vallès Muns <[email protected]> Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
Fixes some problems when calling `make_tracer` on an object that wraps an `Ansatz`, like `Tuple{MPS}` for example.
|
@mofeing Can we close this? This is already on master, right? |
|
mmm yes, we can close. I didn't close it before because I wanted to readd the PEPS (maybe the Dense) types but we can add them later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by ITensorNetworks.jl (but not equal), I experimented with using a graph for representing the connectivity between different sites.
In "ITensorNetworks.jl", they use the graph for representing the structure of the TensorNetwork and the connectivity graph of the different sites, which is useful when dealing with lattices or hamiltonians. Unlike them, the hypergraph structure is already implicit in
TensorNetwork, but it doesn't comfortably accommodate for fixed structured Tensor Networks like MPS, PEPS, TTN, ...By adding a graph field in
Ansatzthat accounts for the connectivity pattern between sites, a lot of the software design problems can be mitigated.I've also refactored
ChainintoMPSandMPOandGridintoPEPSand(actually, I've never seen a PEPO in real life).PEPO@jofrevalles @starsfordummies you might want to reconsider refactoring your PR on top of this.