Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to Infinite trait #111

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Oct 10, 2023

Closes #107
Waiting to #103

@mofeing mofeing added the on hold Blocked due to some reason label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4697c96) 80.04% compared to head (65c9644) 80.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #111      +/-   ##
===========================================
+ Coverage    80.04%   80.22%   +0.18%     
===========================================
  Files           14       14              
  Lines          882      880       -2     
===========================================
  Hits           706      706              
+ Misses         176      174       -2     
Files Coverage Δ
src/Quantum/MP.jl 87.05% <ø> (+1.01%) ⬆️
src/Quantum/PEP.jl 0.00% <ø> (ø)
src/Quantum/Quantum.jl 74.15% <ø> (ø)
src/Tenet.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing mofeing linked an issue Oct 10, 2023 that may be closed by this pull request
@mofeing mofeing removed the on hold Blocked due to some reason label Oct 25, 2023
@mofeing mofeing requested a review from jofrevalles October 25, 2023 08:51
@mofeing mofeing force-pushed the deprecate/infinite-boundary branch from 7e1178c to 65c9644 Compare October 25, 2023 09:49
Copy link
Member

@jofrevalles jofrevalles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok!

@mofeing mofeing merged commit 3891c62 into develop Oct 26, 2023
5 checks passed
@mofeing mofeing deleted the deprecate/infinite-boundary branch October 26, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider deprecating Infinite<:Plug trait
2 participants