Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TensorNetwork to class-based OOP organization #103

Merged
merged 29 commits into from
Oct 25, 2023
Merged

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Oct 6, 2023

This PR starts the process of rewriting current TensorNetwork type hierarchy on more OOP-like classes. It doesn't do all the things we would like from it yet, but we need some other changes and this PR merges the minimum changes in order to proceed with them.

The main change is that we get rid of the "field-inheritance hack using NamedTuple", which although interesting, it doesn't scale well. It also redefines what an Ansatz is and turns Boundary and Plug into traits.

Things yet to do after this PR

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@be2e2e9). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             develop    #103   +/-   ##
=========================================
  Coverage           ?   0.23%           
=========================================
  Files              ?      14           
  Lines              ?     869           
  Branches           ?       0           
=========================================
  Hits               ?       2           
  Misses             ?     867           
  Partials           ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing mofeing marked this pull request as ready for review October 9, 2023 15:57
@mofeing mofeing linked an issue Oct 9, 2023 that may be closed by this pull request
src/TensorNetwork.jl Show resolved Hide resolved
docs/src/transformations.md Outdated Show resolved Hide resolved
@arturgs arturgs merged commit d4d0f78 into develop Oct 25, 2023
5 checks passed
@arturgs arturgs deleted the refactor/oop branch October 25, 2023 08:34
@mofeing mofeing restored the refactor/oop branch October 25, 2023 08:52
@mofeing mofeing deleted the refactor/oop branch October 25, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants