Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add inspection time tracking #331

Open
bryanlundberg opened this issue Jul 14, 2024 · 5 comments
Open

feat: Add inspection time tracking #331

bryanlundberg opened this issue Jul 14, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@bryanlundberg
Copy link
Owner

bryanlundberg commented Jul 14, 2024

It would be a good detail to save the inspection time for people who play using the inspection feature and display it alongside all other statistics.

image

Note:
Right now, the application does not save any kind of inspection times; it needs to be adapted from the beginning.

@bryanlundberg bryanlundberg added the enhancement New feature or request label Jul 14, 2024
@syrok94
Copy link
Contributor

syrok94 commented Jul 16, 2024

Hi @bryanlundberg , assign this to me and please let me know about inspection time.
I checked the code that if a user is playing with inspection time or not but I need to what inspection time is?

@bryanlundberg
Copy link
Owner Author

Hi @bryanlundberg , assign this to me and please let me know about inspection time.

Hi, inspection time its on settings:
image

That feature gives a user 15 seconds of inspection time before starting the timer. WCA

9eeea88a151c251e37ee0305b0b0d188.mp4

@bryanlundberg
Copy link
Owner Author

bryanlundberg commented Jul 16, 2024

if a user is playing with inspection time or not but I need to what inspection time is?

Default inspection time 0, its important save the spent time, not the remaining.

@syrok94
Copy link
Contributor

syrok94 commented Jul 16, 2024

Thanks 👍🏻.

@syrok94
Copy link
Contributor

syrok94 commented Jul 17, 2024

Hey @bryanlundberg ,
Is there an existing method to get the inspection time? Currently, the useTimer hook returns an inspectionTime, but it defaults to 1600. This might be due to re-renders causing it to reset.
I'm considering adding an inspectionTime field to the solve interface and saving the inspection time there. What are your thoughts on this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants