Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Host the full code on Heroku so we can have a working demo. #4

Closed
bryanbraun opened this issue Jun 3, 2013 · 10 comments
Closed

Host the full code on Heroku so we can have a working demo. #4

bryanbraun opened this issue Jun 3, 2013 · 10 comments
Assignees
Milestone

Comments

@bryanbraun
Copy link
Owner

This should probably be done after the next round of fixes and optimizations are set up, so everything is working properly. It depends on: #1, #2 and possibly some others.

Also, once this is up, we should link to it in the readme and add the link here: WhiteHouse/ndoch-hackathon#13

@ghost ghost assigned typesend Jun 3, 2013
@typesend
Copy link
Collaborator

typesend commented Jun 3, 2013

I'm manually migrating over the static html, css, and js into my typesend/we rails app. So going to plain ol' http://wethedata.herokuapp.com/ will soon bring up Bryan's frontend. @bryanbraun @lkhaas

@typesend
Copy link
Collaborator

typesend commented Jun 3, 2013

The working demo is now live at http://wethedata.herokuapp.com/ and I'm holding off with the hostname change until you guys check in your code changes, per #6

@eshtadc
Copy link
Contributor

eshtadc commented Jun 3, 2013

Hey Ben - how can I get the back-end you made to return jsonp instead of raw json?

@typesend
Copy link
Collaborator

typesend commented Jun 3, 2013

I
​ just deployed support for jsonp. Just use the common ?callback=whatever
style based on the existing /issues and /petitions/0/1/9 paths. :)

Note: I added this in such a way that all future api calls we might add in
will automatically have support for JSONP calls.

Rock on.

@eshtadc
Copy link
Contributor

eshtadc commented Jun 4, 2013

Perfect. Did exactly what I needed and I've been able to get the barebones functionality migrated into JS and uploaded into the repo.

@bryanbraun
Copy link
Owner Author

I still need to finish up #1, and we'll need to work the bugs out of #2 and then we should be able to push a fresh and fully functional version up to our Heroku app.

By the way, our project is now featured at https://petitions.whitehouse.gov/how-why/api-gallery. Once we close these last few issues, I'll look into getting a demo link up there.

@typesend
Copy link
Collaborator

I know #1 is still technically open due to the occasional NYT API error, but is now a good time for me to semi-destructively merge the repos together as planned? Or should I continue to hold off until #1 is officially closed for good?

@typesend
Copy link
Collaborator

Okay, merging the two repos was easier than I expected it would be. My complete commit history from typesend/we is now merged into this repository.

The static html and js files still need to be moved to their correct places inside the conventional rails application directory structure...I'm doing this next.

@typesend
Copy link
Collaborator

@bryanbraun @lkhaas Take note of the rather more complex directory structure. To track down your js, css, and html poke around in the /app/assets and /views/layouts and /views/welcome directories. You'll want to do a fresh pull from this repo to update your local copies.

@typesend
Copy link
Collaborator

Okay, well the demo is online and semi-working. Gotta load more data in there and correct whatever issues are remaining with the news api, but I'm closing this ticket nonetheless.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants