Skip to content
This repository has been archived by the owner on Feb 21, 2020. It is now read-only.

Serializer class improvement suggestion #16

Open
hauru opened this issue Feb 26, 2016 · 1 comment
Open

Serializer class improvement suggestion #16

hauru opened this issue Feb 26, 2016 · 1 comment

Comments

@hauru
Copy link

hauru commented Feb 26, 2016

Hi,

first of all, thanks for the recent update. Serializer class seems useful to get the code organized better. I have some additional suggestions though that i hope make sense.

The Serializer-level options could be perhaps implemented as class/instance attributes. This would make it possible to have a base serializer class from which defaults could be inherited. What could also be useful is for the related dictionary to accept Serializer class / instances as values. With these two things together it will be possible to declare and assign common settings in just one place - the base serializer class. It makes sense in case of hooks, for example, when a common logic needs to be executed for any instance of every serializable model.

@bruth
Copy link
Owner

bruth commented Feb 26, 2016

The Serializer-level options could be perhaps implemented as class/instance attributes. This would make it possible to have a base serializer class from which defaults could be inherited.

Good idea. I suppose it can be layered. Class attributes, then instance attributes, then runtime arguments.

What could also be useful is for the related dictionary to accept Serializer class / instances as values.

Yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants