New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom module `stop` function overwrites the module cleanup #72

Open

jantimon opened this issue Jun 15, 2016 · 0 comments

jantimon commented Jun 15, 2016

When specifying a custom stop method the default one gets overwritten.

terrificjs/dist/terrific.js

Lines 598 to 600 in a322f8c

    
           Module.prototype.stop = function () { 
        
           	this._events.off().disconnect(); 
        
           };

I am not sure - is this intended or an error?

The text was updated successfully, but these errors were encountered:

jantimon added a commit to jantimon/terrificjs that referenced this issue


          Fixes memory leaks (see brunschgi#72)

caa4428

jantimon added a commit to jantimon/terrificjs that referenced this issue


          Fixes memory leaks (see brunschgi#72)

e0497f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment