Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phaser_mono.dsp should pass 1 instead of 2 for depth #15

Open
mikeoliphant opened this issue Jun 29, 2020 · 0 comments
Open

phaser_mono.dsp should pass 1 instead of 2 for depth #15

mikeoliphant opened this issue Jun 29, 2020 · 0 comments

Comments

@mikeoliphant
Copy link

Because phaser_mono.dsp is passing '2' for depth to the underlying phaser implementation, it is currently implementing vibrato mode (allpass signal chain only). For phaser mode (equal blend of direct and allpass), it should pass '1' (or pass 'depth' instead of 'mdepth').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant