Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add total hit count to GoogleAnalyticsStats #56

Open
robertvazan opened this issue Jun 6, 2018 · 1 comment
Open

Add total hit count to GoogleAnalyticsStats #56

robertvazan opened this issue Jun 6, 2018 · 1 comment
Milestone
2.1

Comments

@robertvazan
Copy link

robertvazan commented Jun 6, 2018 •
edited
Loading

Currently the GoogleAnalyticsStats exposes separate counters for different hit types, but the most useful total hit counter is missing. Please add it.

While we are at this, consider using micrometer instead of creating your own metrics implementation.
brsanthu added a commit that referenced this issue May 19, 2019
@brsanthu
Add total hits to stats #56
15ef1d0
@brsanthu brsanthu added this to the 2.1 milestone May 20, 2019
@brsanthu
Copy link
Owner

Added getTotalHits stat. Not sure if integrating with micrometer would be a value add considering that it brings additional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@brsanthu @robertvazan