Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could all days have titles? #54

Open
chadwhitacre opened this issue Feb 20, 2024 · 3 comments
Open

Could all days have titles? #54

chadwhitacre opened this issue Feb 20, 2024 · 3 comments

Comments

@chadwhitacre
Copy link

chadwhitacre commented Feb 20, 2024

I have been depending on titles in the Gospel Desk API, but not all days have at least one title. Could they? 🤔

I find only a few days without a title:

(orthocal) $ sqlite3 db.sqlite3 "select pdist, title from calendarium_day where pdist < 999 and title='';"
-76|
-75|
-74|
-73|
-72|
-71|
-69|
-68|
-67|
-66|
-65|
-64|
(orthocal) $ sqlite3 db.sqlite3 "select pdist, title from calendarium_day where pdist < -62;"
-77|Sunday of Zacchaeus
-76|
-75|
-74|
-73|
-72|
-71|
-70|Sunday of the Publican and the Pharisee
-69|
-68|
-67|
-66|
-65|
-64|
-63|Sunday of the Prodigal Son

Would the following work?

-77|Sunday of Zacchaeus
-76|Monday after Zacchaeus Sunday
-75|Tuesday after Zacchaeus Sunday
-74|Wednesday after Zacchaeus Sunday
-73|Thursday after Zacchaeus Sunday
-72|Friday after Zacchaeus Sunday
-71|Saturday after Zacchaeus Sunday
-70|Sunday of the Publican and the Pharisee
-69|Monday after Publican and Pharisee
-68|Tuesday after Publican and Pharisee
-67|Wednesday after Publican and Pharisee
-66|Thursday after Publican and Pharisee
-65|Friday after Publican and Pharisee
-64|Saturday after Publican and Pharisee
-63|Sunday of the Prodigal Son
chadwhitacre added a commit to gospeldesk/api.gospeldesk.org that referenced this issue Feb 20, 2024
chadwhitacre added a commit to gospeldesk/api.gospeldesk.org that referenced this issue Feb 20, 2024
@chadwhitacre
Copy link
Author

chadwhitacre commented Feb 20, 2024

(P.S. It took a few more commits but I have the Gospel Desk API back up. 😬)

@brianglass
Copy link
Owner

@chadwhitacre, sorry, just noticed this. I'd need to look a little closer at this. My full calendar view depends on titles being missing to render each day properly. I could probably rewrite some of that, but it's not something I can change without consequences.

@brianglass
Copy link
Owner

@chadwhitacre, I forgot to mention the summary_title field. This should always be populated and is an attempt to pull the most appropriate thing from feasts, saints, or titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants