-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite does not pass against Sphinx 7.2.6 #975
Comments
gareth-rees
added a commit
to gareth-rees/breathe
that referenced
this issue
Mar 31, 2024
Sphinx was updated in in pull request sphinx-doc/sphinx#11526 (July 2023) so that importing `sphinx.testing.path` no longer causes Sphinx application paths to belong to the class `sphinx.testing.path.path`, which has a `makedirs` method. Instead, Sphinx application paths are now ordinary `Path` objects which lack this method, so we use `os.makedirs` instead. This is backwards compatible as `sphinx.testing.path.path` objects are pathlike and so accepted by `os.makedirs`. Fixes issue breathe-doc#975.
This was referenced Mar 31, 2024
5 tasks
2bndy5
pushed a commit
to 2bndy5/breathe
that referenced
this issue
Jun 18, 2024
Sphinx was updated in in pull request sphinx-doc/sphinx#11526 (July 2023) so that importing `sphinx.testing.path` no longer causes Sphinx application paths to belong to the class `sphinx.testing.path.path`, which has a `makedirs` method. Instead, Sphinx application paths are now ordinary `Path` objects which lack this method, so we use `os.makedirs` instead. This is backwards compatible as `sphinx.testing.path.path` objects are pathlike and so accepted by `os.makedirs`. Fixes issue breathe-doc#975.
Fixed by #976. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running the Breathe test suite (as of commit 542ae9b) against Sphinx 7.2.6, all the tests in
test_renderer.py
fail with an error like this:Complete output from `make dev-test`
When
sphinx.testing.path
is imported, Sphinx application paths used to belong to the classsphinx.testing.path.path
(which has amakedirs
method) but now they are ordinaryPath
objects (which does not). Note also that we get this warning:The Sphinx behaviour was changed in pull request sphinx-doc/sphinx#11526 (July 2023).
The text was updated successfully, but these errors were encountered: