You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I’m not quite sure why it was done this way, but gomemcache creates a ConnectTimeoutError instead of the standard i/o timeout or net.OpError.
This, in turn, does not have the Timeout() and Temporary() methods to satisfy the net.Error interface, obfuscating the error handling for clients.
In our library, we ended up recreating a net.OpError: Shopify/goose#35
Could you clarify why it was done way?
I would suggest getting rid of ConnectTimeoutError and instead wrapping the poll.TimeoutError in a net.OpError to satisfy the interface and retain proper messaging.
The text was updated successfully, but these errors were encountered:
lavoiesl
changed the title
ConnectTimeoutError should be net.Error
ConnectTimeoutError should satisfy net.Error
Mar 25, 2019
I'm really at a loss on how to process because it only says "connection timeout' and the docs say 'we shouldn't worry about this level of detail'. Not much help tbh.
I’m not quite sure why it was done this way, but gomemcache creates a
ConnectTimeoutError
instead of the standardi/o timeout
ornet.OpError
.This, in turn, does not have the
Timeout()
andTemporary()
methods to satisfy thenet.Error
interface, obfuscating the error handling for clients.In our library, we ended up recreating a
net.OpError
: Shopify/goose#35Could you clarify why it was done way?
I would suggest getting rid of
ConnectTimeoutError
and instead wrapping thepoll.TimeoutError
in anet.OpError
to satisfy the interface and retain proper messaging.The text was updated successfully, but these errors were encountered: