Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up github workflows #3

Open
2 of 4 tasks
braaar opened this issue Jan 2, 2022 · 6 comments
Open
2 of 4 tasks

Set up github workflows #3

braaar opened this issue Jan 2, 2022 · 6 comments

Comments

@braaar
Copy link
Owner

braaar commented Jan 2, 2022

Right now we have the bare minimum in terms of CI/CD. More actions could allow us to do more fancy stuff or facilitate good coding practices

  • linting
  • prettier
  • test and build on PR
  • github-pages release
@RishiKumarRay
Copy link
Contributor

I see 2 github actions file i.e we can integrate that in one? like why different files for push and pull , we can just add push and pull both in one?

@braaar
Copy link
Owner Author

braaar commented Jan 24, 2022

I see 2 github actions file i.e we can integrate that in one? like why different files for push and pull , we can just add push and pull both in one?

I like having separate files for separate actions, personally. I think it makes it easier to keep track of what is doing what. What is the advantage of putting it all in one file?

@RishiKumarRay
Copy link
Contributor

Oh i see, not a problem that, I don't know of any advantage but yeah just a practice i guess

@RishiKumarRay
Copy link
Contributor

@braaar i was reading about linting, came to know about super linter provided by github check this out, maybe we can implement in linting ? or if you have thought of anything else let me know?

@braaar
Copy link
Owner Author

braaar commented Jan 24, 2022

I don't really see why we would need anything more than just a standard yarn lint with eslint. At least for the moment I'm not planning to add any special languages.

@RishiKumarRay
Copy link
Contributor

@braaar i have a raised a PR adding lint , please do check , i read and applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants