Upload Java 8 to Boxen S3

[petems]

Blocks #57

[dgoodlad]

@petems none of the previous maintainers have access to the boxen-downloads S3 bucket anymore, since it's owned by GitHub.

@MikeMcQuaid can you ping @github/security and get that sorted out, at least for yourself?

[MikeMcQuaid]

@dgoodlad I'd like to try and work out a solution that doesn't involve a GitHubber manually uploading to an S3 bucket.
@petems Is there anywhere else that there are direct URLs provided for these?

[petems]

@MikeMcQuaid Haven't found anywhere yet. I mean technically, companies could upload to their own S3s for their Boxen setup, so the PR could be merged, but it would be much easier if the Boxen S3 had it so people didnt have to set it up themselves.

[MikeMcQuaid]

@petems Yeh, I agree. I'm just trying to work out ways that don't require someone from GitHub to upload these. I'm wondering if there's an Oracle URL we can link directly to or some other mirror. Would you mind taking a look?

[petems]

@MikeMcQuaid The Oracle website download stuff behind a wall of sign-ups:

In order to download products from Oracle Technology Network you must agree to the OTN license terms.

Be sure that...
 Your browser has "cookies" and JavaScript enabled.
 You clicked on "Accept License" for the product you wish to download.
 You attempt the download within 30 minutes of accepting the license.

There's a few random Universities that have unprotected links, but I think that's kind of mean to use...

[MikeMcQuaid]

https://github.com/caskroom/homebrew-cask/blob/master/Casks/java.rb gives us an option, I think. Looks like we just need to set a single cookie variable.

[petems]

Does the DMG provider have that kind of complexity?

[MikeMcQuaid]

Probably not currently but we could either potentially add it or use something else to download it first.

[MikeMcQuaid]

https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/package/pkgdmg.rb is the relevant file. I guess you could subclass it to inject a curl cookie argument?

[MikeMcQuaid]

Maybe we could upload this using the GitHub Releases feature instead?

[rafaelfranca]

@MikeMcQuaid this could work.

[ghost]

homebrew-cask is up-to-date to Java 8 for several months

Why maintain this recipe?

[MikeMcQuaid]

@julienlavergne Because this module supports different things to Homebrew Cask.

[danielr-minted]

Can we separate the requirements to make uploads work how they should from the requirements that java 8 work at all? I'd really like java 8 working, and where I get the tarball from isn't super important from a user perspective.

[MikeMcQuaid]

@danielr-minted That's fine. This issue was created as currently it requires someone from GitHub to upload it to the S3 bucket. If you have another solution and a pull-request: let's go for that instead.