diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md index 9f15b2b7c2..d7a35b1242 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.md +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -3,12 +3,12 @@ name: "Bug Report" about: Submit a bug report to help us improve GTSAM --- + + - - ## Description diff --git a/containers/hub_push.sh b/containers/hub_push.sh old mode 100644 new mode 100755 diff --git a/gtsam/linear/linear.i b/gtsam/linear/linear.i index eecc0192c3..6b454af05e 100644 --- a/gtsam/linear/linear.i +++ b/gtsam/linear/linear.i @@ -733,10 +733,10 @@ virtual class BlockJacobiPreconditionerParameters : gtsam::PreconditionerParamet #include virtual class PCGSolverParameters : gtsam::ConjugateGradientParameters { PCGSolverParameters(); - PCGSolverParameters(gtsam::PreconditionerParameters* preconditioner); + PCGSolverParameters(const gtsam::PreconditionerParameters* preconditioner); void print(string s = ""); - - gtsam::PreconditionerParameters* preconditioner; + + std::shared_ptr preconditioner; }; #include diff --git a/gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h b/gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h index bd106afbed..e3d90a5913 100644 --- a/gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h +++ b/gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h @@ -146,7 +146,7 @@ double lineSearch(const S &system, const V currentValues, const W &gradient) { double newError = system.error(newValues); while (true) { - const bool flag = (maxStep - newStep > newStep - minStep) ? true : false; + const bool flag = (maxStep - newStep > newStep - minStep); const double testStep = flag ? newStep + resphi * (maxStep - newStep) : newStep - resphi * (newStep - minStep); diff --git a/gtsam/nonlinear/internal/ChiSquaredInverse.h b/gtsam/nonlinear/internal/ChiSquaredInverse.h index dbf83f92b4..6707be1fe3 100644 --- a/gtsam/nonlinear/internal/ChiSquaredInverse.h +++ b/gtsam/nonlinear/internal/ChiSquaredInverse.h @@ -36,7 +36,7 @@ namespace internal { * @param alpha Quantile value * @return double */ -double chi_squared_quantile(const double dofs, const double alpha) { +inline double chi_squared_quantile(const double dofs, const double alpha) { return 2 * igami(dofs / 2, alpha); }