Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing with unsaved Sketch file in background #89

Open
benjamindenboer opened this issue Feb 13, 2015 · 8 comments
Open

Importing with unsaved Sketch file in background #89

benjamindenboer opened this issue Feb 13, 2015 · 8 comments
Assignees
Labels

Comments

@benjamindenboer
Copy link
Collaborator

When trying to import a saved, active file while having an unsaved document in the background, Sketch and Framer both throw errors and the import fails.

sketchim

imf

Not necessarily a big issue. But it should be possible to import a valid, saved and active document regardless of what documents you have opened in the background.

@bomberstudios
Copy link
Owner

Can't reproduce here, is this still an issue, @benjaminnathan and @koenbok?

@koenbok
Copy link
Collaborator

koenbok commented Nov 9, 2015

Yes this is actually a Sketch issue. Repro:

  • Make new document
  • Open existing document
  • Focus on new document
  • Minimize new document
  • Import in Framer

You now get a bunch of warnings. Apparently Sketch still thinks the minimized document is the frontmost one.

@bomberstudios
Copy link
Owner

I think that's actually a new issue in Sketch (context.document points to the wrong thing under some circumstances, like following the steps you outlined) and is technically not related to save state. Anyway, we're about to fix it so those steps are really handy to reproduce the issue : )

@bomberstudios
Copy link
Owner

This is fixed in Sketch 3.4.2 15853 (a beta is coming out shortly). I'll leave this open until you can confirm the fix : )

@bomberstudios
Copy link
Owner

Ping @benjaminnathan and @koenbok: did you have a chance to try the latest Sketch beta? I'd love to confirm this issue has been fixed for good : )

@koenbok
Copy link
Collaborator

koenbok commented Dec 18, 2015

I think I just saw this again :-/

@koenbok
Copy link
Collaborator

koenbok commented Dec 18, 2015

Basically Sketch still seems confused if:

  • It's in the background OR
  • Some docs are minimized

@bomberstudios
Copy link
Owner

: (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants