Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check for body in truncateWords method #10

Open
garak opened this issue Jun 12, 2022 · 0 comments
Open

Missing check for body in truncateWords method #10

garak opened this issue Jun 12, 2022 · 0 comments

Comments

@garak
Copy link

garak commented Jun 12, 2022

It looks like this repository is abandoned, with the last commit 7 years old. Anyway, I see there's some activity in issues/PR, so I'm optimistic.

The problem is just afterhttps://github.com/bluetel/twig-truncate-extension/blob/master/src/TruncateExtension.php#L62 where the value of $body is not checked. Such value can be null, sot the following call new DOMWordsIterator($body) can result into TypeError Argument 1 passed to DOMLettersIterator::__construct() must be an instance of DOMNode, null given

I can provide a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant