Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: remove restrictions on some RunStart document keys #225

Open
danielballan opened this issue Aug 10, 2022 · 2 comments
Open

Proposal: remove restrictions on some RunStart document keys #225

danielballan opened this issue Aug 10, 2022 · 2 comments

Comments

@danielballan
Copy link
Member

danielballan commented Aug 10, 2022

The reserved words in the RunStart document are:

data_session
data_groups
project
sample
scan_id
time
uid
group
owner
projections
hints

I propose to remove any validation/restrictions on:

project
sample
group
owner

The owner and group are documented as meaning associated "UNIX" owner/group. In practice, this is a rare (unused?) way to mark up ownership in Bluesky. It's often associated with proposals (or analogous entities) rather than individuals, and with some account other than a UNIX one.

We insist on sample being a string or a dict. I don't think we had a very good reason for this. Samples certainly could be numerical.

Finally, project is also unused and somewhat undefined. Individual deployments can define what this means.

I think that, with hindsight, this system is either too much validation or not enough. Should we take a lighter touch?

@cjtitus
Copy link
Contributor

cjtitus commented Nov 7, 2022

Just want to say that I would like this to happen! I'm waiting for this so that I can re-work my beamline's run metadata. I would like to see restrictions removed on all 4 of the mentioned keys.

@prjemian
Copy link
Contributor

prjemian commented Nov 7, 2022

Should we take a lighter touch?

My upvote is for lighter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants