Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_message works with a different api than wait_message #89

Open
patrickelectric opened this issue Mar 20, 2020 · 0 comments · May be fixed by #123
Open

get_message works with a different api than wait_message #89

patrickelectric opened this issue Mar 20, 2020 · 0 comments · May be fixed by #123
Milestone
1.0.0

Comments

@patrickelectric
Copy link
Member

wait_message returns an object, you can access the item via: message.data
get_message returns an dict, you can only access the item via : message['data']

This results in a weird and not consistent api for our users.
@ES-Alexander ES-Alexander added this to the 0.2.0 milestone Dec 2, 2021
@ES-Alexander ES-Alexander linked a pull request Mar 20, 2022 that will close this issue
Draft
18 tasks
@ES-Alexander ES-Alexander changed the title get_message works with a different api that wait_message get_message works with a different api than wait_message Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Interface improvements ES-Alexander/ping-python
2 participants
@patrickelectric @ES-Alexander