-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Echosounder S500 - ping-python implementation ? #142
Comments
Hi @Tchiimy :-) We're happy for people to contribute extensions or new device types to the ping protocol, but manually modifying the auto-generated files (instead of the protocol and/or the template files) is not the recommended approach for doing so, and makes it hard to determine whether there's an error in your code implementation or in the way you tried to specify the messages. I'd recommend modifying the relevant protocol definition file(s) instead (in the I would also note that the API docs you linked to specify the S500 supports most of the Ping1D messages, but isn't clear which messages or fields it doesn't support, which makes it harder to know whether a proposed S500 definition file is correct. |
Hi @ES-Alexander :-) Thanks for your answer, for the context we were mainly trying to implement the functions We "manually modified" the definitions.py by adding:
The pingmessage.py with: And the ping1d.py with:
We didn't knew about the generation method, if I understood I need to add the modifications in ping1d.json and then run the src/generate-markdown.py right ? Or is it better to separate the devices and make a S500.json file instead ? |
If it's just for personal use (and you know you're not going to accidentally use the S500-exclusive methods when communicating with a device which only implements the Ping1D protocol) then directly extending the Ping1D file is the simplest approach to get something that works. If you're wanting to contribute to the ping-protocol repository and/or the ping-python library then keeping the extra messages separate makes sense, to avoid confusion over which messages each device supports. Then you'd want to make a file
That one is for documentation of ping-protocol. In the ping-python repo the file you want to run is |
Hello,
I'm trying to use the functions you are defining in this api related to the S500 echosounder.
From what I understood the ping-python library is "general" but I tried to make some modifications in the definitions.py and ping1D.py to add these functions for the api:
I tried to manually add the definitions and functions in the library:
definitions.py:
and pind1D.py:
Then I made a basic test with my S500:
And got theses output:
I send you the modified files if you require it:
test (2).zip
Did I missed something in my try ?
The text was updated successfully, but these errors were encountered: