Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove property removal from validation middleware #22

Open
AlmogVC opened this issue Jan 3, 2019 · 0 comments
Open

Remove property removal from validation middleware #22

AlmogVC opened this issue Jan 3, 2019 · 0 comments
Assignees
@Ron537
Labels
invalid This doesn't seem right refactor Code to be refactored

Comments

@AlmogVC
Copy link
Contributor

AlmogVC commented Jan 3, 2019

The validation middleware should not manipulate/affect the data, separate the data manipulation to a different layer.

blue-stream-video/src/video/validator/video.validator.ts

Line 17 in a7c1f4f

delete req.body.contentPath;

@AlmogVC AlmogVC added the invalid This doesn't seem right label Jan 3, 2019
@Ron537 Ron537 added the refactor Code to be refactored label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ron537 Ron537

Labels
invalid This doesn't seem right refactor Code to be refactored
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ron537 @AlmogVC