Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Translate install list of flatpaks from default-flatpaks module into ISO action #20

Open
fiftydinar opened this issue Feb 23, 2024 · 5 comments

Comments

@fiftydinar
Copy link
Collaborator

fiftydinar commented Feb 23, 2024

Users would not need to wait for flatpaks to install once they boot into the system.
That installation step will be in the ISO installer screen instead.

Related issue, which is in-progress:
ublue-os/isogenerator#9

@fiftydinar
Copy link
Collaborator Author

I think that this issue can be closed, unless it can be useful for generating offline ISO?

@xynydev
Copy link
Member

xynydev commented Mar 21, 2024

I don't know how the Flatpak inclusion works, or if that's even implemented yet. I'm also doubting / delaying the creation of an ISO action for a few reasons:

  1. Upload limits would require some configuration of the server where the ISOs are uploaded by the user, so it wouldn't be that automatic.
  2. A list of ISOs would also have to be configured, which also wouldn't be that automatic.
  3. Both of those things would be / are handled by the upstream action, which we could just provide a guide for adding to ones repo.
  4. The ISO action would only be useful for building on Fedora, other OSs that might be supported in the future for ISOs would have to have other mechanisms.
  5. The only benefit an ISO action from us would provide is this Flatpak auto-conf feature, and while I'm pretty sure we could do a reasonably simple implementation that traverses the recipe to pick the Flatpaks to add to the ISO, it would be adding a new semantic meaning for the default-flatpaks module that isn't totally functionally related. Someone might want to include only a small set of Flatpaks in the ISO to keep file sizes smaller, for example, and install the rest from the internet post-install.

@fiftydinar
Copy link
Collaborator Author

You are right on all points imo, so I think that provided easy guide for making ISOs would be enough.
If Universal Blue adds support for online ISOs, we would update the guide with that option too to be automatic, like it was with old action.

@gmpinder
Copy link
Member

gmpinder commented Mar 22, 2024

So I looked at ublue's new ISO generator and it looks like something that we could add to the CLI for people to build one for themselves locally. We've already got drivers for running builds, we could support running their new image to create the ISO.

@xynydev 's point still stands though that we wouldn't be able to put that in the action since there isn't a good way to store it

@xynydev
Copy link
Member

xynydev commented Mar 23, 2024

That'd be cool! I was thinking of ISO generation for the planned GUI, but of course it would work with the CLI as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants