-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing license info in packaging #187
base: master
Are you sure you want to change the base?
Conversation
@debodirno @rozuur @navinpai - could you pls advise why the test is failing when I just modified some licensing setup for packaging? Having a quick glance on the test script it does not seem to build a package, so I don't know how could I break an assumably correctly running test in master. |
Try pushing your code to a branch in this remote. Travis CI has an issue with forks. Will soon move from Travis CI to Github Actions. |
I have no permission to push a branch into this repo. If you grant me perm I am happy to do it. |
@debodirno Let's migrate from Travis to Github actions, as a part of that effort this commit can be merged. @z-kovacs Care to work on this migration? |
I can take a stab...first run seems to show same errors as travis |
The error I see:
|
@@ -839,7 +841,7 @@ fi | |||
|
|||
|
|||
echo 'Initializing...' | |||
initialize > /dev/null 2>&1 | |||
initialize #> /dev/null 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't pollute the stdout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debodirno - sure, pls have a look of my previous comment - where I wanted to see what is the error when trying to run the tests using github actions. To see error messages I had to comment the redirection. I a happy to comment it back, but I assume you are not merging without green tests? Let me know pls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am checking what we can do to get the repository active again for development and contribution.
Pls review and merge if possible.