Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing license info in packaging #187

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

z-kovacs
Copy link

Pls review and merge if possible.

@z-kovacs
Copy link
Author

@debodirno @rozuur @navinpai - could you pls advise why the test is failing when I just modified some licensing setup for packaging? Having a quick glance on the test script it does not seem to build a package, so I don't know how could I break an assumably correctly running test in master.
Pls advise.
Thanks!

@debodirno
Copy link
Contributor

@debodirno @rozuur @navinpai - could you pls advise why the test is failing when I just modified some licensing setup for packaging? Having a quick glance on the test script it does not seem to build a package, so I don't know how could I break an assumably correctly running test in master.
Pls advise.
Thanks!

Try pushing your code to a branch in this remote. Travis CI has an issue with forks. Will soon move from Travis CI to Github Actions.
Read for more information : https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

@z-kovacs
Copy link
Author

@debodirno @rozuur @navinpai - could you pls advise why the test is failing when I just modified some licensing setup for packaging? Having a quick glance on the test script it does not seem to build a package, so I don't know how could I break an assumably correctly running test in master.
Pls advise.
Thanks!

Try pushing your code to a branch in this remote. Travis CI has an issue with forks. Will soon move from Travis CI to Github Actions.
Read for more information : https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

I have no permission to push a branch into this repo. If you grant me perm I am happy to do it.

@rozuur
Copy link
Contributor

rozuur commented Jan 22, 2021

@debodirno Let's migrate from Travis to Github actions, as a part of that effort this commit can be merged.

@z-kovacs Care to work on this migration?

@z-kovacs
Copy link
Author

@debodirno Let's migrate from Travis to Github actions, as a part of that effort this commit can be merged.

@z-kovacs Care to work on this migration?

I can take a stab...first run seems to show same errors as travis

@z-kovacs
Copy link
Author

@debodirno Let's migrate from Travis to Github actions, as a part of that effort this commit can be merged.
@z-kovacs Care to work on this migration?

I can take a stab...first run seems to show same errors as travis

The error I see:

  (D)s4cmd.py:128  >> del_handler(<__main__.CommandHandler object at 0x7f2d0b4f68d0>, ['del', 's3://bucket/path/0/3.6.12/'])
  (D)s4cmd.py:128  >> validate(<__main__.CommandHandler object at 0x7f2d0b4f68d0>, 'cmd|s3', ['del', 's3://bucket/path/0/3.6.12/'])
  (D)s4cmd.py:130  << validate(<__main__.CommandHandler object at 0x7f2d0b4f68d0>, 'cmd|s3', ['del', 's3://bucket/path/0/3.6.12/']): None
  (D)s4cmd.py:128  >> del_files(<__main__.S3Handler object at 0x7f2d10709f28>, 's3://bucket/path/0/3.6.12/')
  (D)s4cmd.py:128  >> s3walk(<__main__.S3Handler object at 0x7f2d10709f28>, 's3://bucket/path/0/3.6.12/')
  (D)s4cmd.py:128  >> s3walk(<ThreadUtil(Thread-1, started daemon 139831427458816)>, <__main__.S3URL object at 0x7f2d0a93eef0>, 'path/0/3.6.12', 'path/0/3.6.12', [])
  (D)s4cmd.py:401  >> S3APICALL get_paginator('list_objects')
  (D)s4cmd.py:403  << S3APICALL get_paginator('list_objects'): <botocore.client.S3.Paginator.ListObjects object at 0x7f2d086b3e80>
  (E)s4cmd.py:182  [Exception] Unable to locate credentials
  (E)s4cmd.py:182  [Thread Failure] Unable to locate credentials

@@ -839,7 +841,7 @@ fi


echo 'Initializing...'
initialize > /dev/null 2>&1
initialize #> /dev/null 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't pollute the stdout.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debodirno - sure, pls have a look of my previous comment - where I wanted to see what is the error when trying to run the tests using github actions. To see error messages I had to comment the redirection. I a happy to comment it back, but I assume you are not merging without green tests? Let me know pls.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am checking what we can do to get the repository active again for development and contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants