Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include element parsing errors in final diff results instead of failing #69

Open
kwridan opened this issue Oct 19, 2020 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@kwridan
Copy link
Contributor

kwridan commented Oct 19, 2020

Is your feature request related to a problem? Please describe.

Recently working with @natanrolnik we noticed running xcdiff fails due to an incorrect path in one of the projects, thanks to #64 the source of the error was identified, however sadly as it wasn't immediately actionable it resulted in the inability to see the diff results for the remaining elements which were needed.

Describe the solution you'd like

Potentially log errors or collect errors and post them in the final diff result while continuing to perform a diff on other elements. This allows users to see a best effort diff while clearly seeing some of the elements which could not be diffed.

Describe alternatives you've considered

  • Ignore errors, however this could yield false results (e.g. no diff if all elements fail to parse for any reason) as such is probably not a suitable alternative.
@kwridan kwridan added the enhancement New feature or request label Oct 19, 2020
@marciniwanicki marciniwanicki self-assigned this Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants