Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support wei variable in interpretation #2347

Merged
merged 1 commit into from
Nov 4, 2024
Merged

support wei variable in interpretation #2347

merged 1 commit into from
Nov 4, 2024

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented Oct 31, 2024 •
edited
Loading

Description and Related Issue(s)

resolves #2332

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@isstuev isstuev marked this pull request as ready for review November 1, 2024 10:38
@isstuev isstuev requested a review from tom2drum November 1, 2024 10:38
tom2drum
tom2drum approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@tom2drum tom2drum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test suite to cover this case?

@isstuev
Copy link
Collaborator Author

isstuev commented Nov 4, 2024

Can we add a test suite to cover this case?

I think unit test should be enough

@isstuev isstuev merged commit 625b4d7 into main Nov 4, 2024
12 checks passed
@isstuev isstuev deleted the fe-2332 branch November 4, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support 'wei' variable in interpretation
2 participants
@isstuev @tom2drum