Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon generator: replace realfavicon with favicons package #2319

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented Oct 23, 2024

Description and Related Issue(s)

resolves #2287

Proposed Changes

[Specify the changes or additions made in this pull request. Please mention if any changes were made to the ENV variables]

Breaking or Incompatible Changes

[Describe any breaking or incompatible changes introduced by this pull request. Specify how users might need to modify their code or configurations to accommodate these changes.]

Additional Information

[Include any additional information, context, or screenshots that may be helpful for reviewers.]

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@isstuev isstuev marked this pull request as ready for review October 25, 2024 12:01
@isstuev isstuev requested a review from tom2drum October 25, 2024 12:01
@tom2drum tom2drum added the ENVs label Oct 28, 2024
Dockerfile Outdated Show resolved Hide resolved
public/assets/favicon/apple-touch-icon-180x180.png Outdated Show resolved Hide resolved
tools/scripts/favicon-generator.dev.sh Show resolved Hide resolved
deploy/tools/favicon-generator/index.js Outdated Show resolved Hide resolved
@isstuev isstuev requested a review from tom2drum October 29, 2024 11:25
@isstuev isstuev merged commit af0baef into main Nov 1, 2024
12 checks passed
@isstuev isstuev deleted the fe-2287 branch November 1, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicon generator: support new API version
2 participants