Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filecoin addresses support #2248

Merged
merged 5 commits into from
Nov 4, 2024
Merged

filecoin addresses support #2248

merged 5 commits into from
Nov 4, 2024

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented Sep 17, 2024

Description and Related Issue(s)

resolves #2195

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@isstuev isstuev added the need API For issues that wait for API changes label Sep 20, 2024
@isstuev isstuev force-pushed the fe-2195 branch 2 times, most recently from 0dc8258 to 2c8b228 Compare October 24, 2024 11:27
@isstuev isstuev changed the title Fe 2195 filecoin addresses support Oct 24, 2024
@isstuev isstuev marked this pull request as ready for review October 28, 2024 11:25
@isstuev isstuev requested a review from tom2drum October 28, 2024 11:25
@tom2drum tom2drum removed the need API For issues that wait for API changes label Nov 4, 2024
tom2drum
tom2drum approved these changes Nov 4, 2024
View reviewed changes
types/api/addressParams.ts Outdated Show resolved Hide resolved
ui/address/AddressDetails.tsx Outdated Show resolved Hide resolved
ui/pages/Address.tsx Outdated Show resolved Hide resolved
@isstuev isstuev merged commit 8facbe5 into main Nov 4, 2024
7 checks passed
@isstuev isstuev deleted the fe-2195 branch November 4, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filecoin native addresses
2 participants
@isstuev @tom2drum