Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor array parameters are displayed as concatenated strings instead of arrays #2394

Closed
anson-caldera opened this issue Nov 14, 2024 · 1 comment · Fixed by #2407
Closed
Assignees
Labels
bug Something isn't working

Comments

@anson-caldera
Copy link

Description

The constructor arguments of a verified contract don't properly display arrays.

In the image, _origins should be [123,456] but is displayed as just 123456. Same for signers, which is an array of two addresses. The contract is properly created and these are the parameters that successfully pass on the evm, so it is definitely a display issue.

image

Firefox 132.0.1, macos.

Type of the installation

Docker-compose

Type of the JSON RPC archive node

geth

Type of the chain

No response

Link to the page

No response

Steps to reproduce

No response

Backend version

v6.8.1

Frontend version

v3.4.2

Elixir & Erlang/OTP versions

unknown

Operating system

No response

Additional information

No response

@anson-caldera anson-caldera added the triage Issues and PRs that are needed triage label Nov 14, 2024
@sl1depengwyn sl1depengwyn transferred this issue from blockscout/blockscout Nov 14, 2024
@sl1depengwyn
Copy link
Contributor

Here is live example https://eth-sepolia.blockscout.com/address/0x9498bB3CbFc01F8F8774faf306F11e4377D6F29d?tab=contract
api response is correct afaik

{
    "has_methods_read": true,
    "is_self_destructed": false,
    "has_custom_methods_write": false,
    "file_path": null,
    "source_code": "// SPDX-License-Identifier: GPL-3.0\n\npragma solidity >=0.8.2 <0.9.0;\n\n/**\n * @title Storage\n * @dev Store & retrieve value in a variable\n * @custom:dev-run-script ./scripts/deploy_with_ethers.ts\n */\ncontract Storage {\n\n    constructor(int32[] memory asd) {}\n\n    uint256 number;\n\n    /**\n     * @dev Store value in variable\n     * @param num value to store\n     */\n    function store(uint256 num) public {\n        number = num;\n    }\n\n    /**\n     * @dev Return value \n     * @return value of 'number'\n     */\n    function retrieve() public view returns (uint256){\n        return number;\n    }\n}",
    "deployed_bytecode": "0x608060405234801561001057600080fd5b50600436106100365760003560e01c80632e64cec11461003b5780636057361d14610059575b600080fd5b610043610075565b60405161005091906100a1565b60405180910390f35b610073600480360381019061006e91906100ed565b61007e565b005b60008054905090565b8060008190555050565b6000819050919050565b61009b81610088565b82525050565b60006020820190506100b66000830184610092565b92915050565b600080fd5b6100ca81610088565b81146100d557600080fd5b50565b6000813590506100e7816100c1565b92915050565b600060208284031215610103576101026100bc565b5b6000610111848285016100d8565b9150509291505056fea2646970667358221220aecd01e0d16e66f276a3ca78a55b432b8bf48ca90a07b5a28c64642b7dea35fc64736f6c63430008120033",
    "optimization_enabled": false,
    "verified_twin_address_hash": null,
    "is_verified": true,
    "compiler_settings": null,
    "optimization_runs": null,
    "sourcify_repo_url": null,
    "decoded_constructor_args": [
        [
            [
                "1",
                "2",
                "3"
            ],
            {
                "internalType": "int32[]",
                "name": "asd",
                "type": "int32[]"
            }
        ]
    ],
    "has_methods_write": true,
    "compiler_version": "v0.8.18+commit.87f61d96",
    "is_verified_via_verifier_alliance": false,
    "verified_at": "2024-11-14T09:48:23.174572Z",
    "implementations": [],
    "proxy_type": null,
    "external_libraries": [],
    "creation_bytecode": "0x608060405234801561001057600080fd5b50604051610386380380610386833981810160405281019061003291906101de565b50610227565b6000604051905090565b600080fd5b600080fd5b600080fd5b6000601f19601f8301169050919050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052604160045260246000fd5b61009a82610051565b810181811067ffffffffffffffff821117156100b9576100b8610062565b5b80604052505050565b60006100cc610038565b90506100d88282610091565b919050565b600067ffffffffffffffff8211156100f8576100f7610062565b5b602082029050602081019050919050565b600080fd5b60008160030b9050919050565b6101248161010e565b811461012f57600080fd5b50565b6000815190506101418161011b565b92915050565b600061015a610155846100dd565b6100c2565b9050808382526020820190506020840283018581111561017d5761017c610109565b5b835b818110156101a657806101928882610132565b84526020840193505060208101905061017f565b5050509392505050565b600082601f8301126101c5576101c461004c565b5b81516101d5848260208601610147565b91505092915050565b6000602082840312156101f4576101f3610042565b5b600082015167ffffffffffffffff81111561021257610211610047565b5b61021e848285016101b0565b91505092915050565b610150806102366000396000f3fe608060405234801561001057600080fd5b50600436106100365760003560e01c80632e64cec11461003b5780636057361d14610059575b600080fd5b610043610075565b60405161005091906100a1565b60405180910390f35b610073600480360381019061006e91906100ed565b61007e565b005b60008054905090565b8060008190555050565b6000819050919050565b61009b81610088565b82525050565b60006020820190506100b66000830184610092565b92915050565b600080fd5b6100ca81610088565b81146100d557600080fd5b50565b6000813590506100e7816100c1565b92915050565b600060208284031215610103576101026100bc565b5b6000610111848285016100d8565b9150509291505056fea2646970667358221220aecd01e0d16e66f276a3ca78a55b432b8bf48ca90a07b5a28c64642b7dea35fc64736f6c6343000812003300000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000003000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000003",
    "name": "Storage",
    "is_blueprint": false,
    "license_type": "none",
    "is_fully_verified": false,
    "has_methods_read_proxy": false,
    "is_vyper_contract": false,
    "is_verified_via_eth_bytecode_db": false,
    "language": "solidity",
    "evm_version": "default",
    "can_be_visualized_via_sol2uml": true,
    "has_methods_write_proxy": false,
    "has_custom_methods_read": false,
    "is_verified_via_sourcify": false,
    "additional_sources": [],
    "certified": false,
    "abi": [
        {
            "inputs": [
                {
                    "internalType": "int32[]",
                    "name": "asd",
                    "type": "int32[]"
                }
            ],
            "stateMutability": "nonpayable",
            "type": "constructor"
        },
        {
            "inputs": [],
            "name": "retrieve",
            "outputs": [
                {
                    "internalType": "uint256",
                    "name": "",
                    "type": "uint256"
                }
            ],
            "stateMutability": "view",
            "type": "function"
        },
        {
            "inputs": [
                {
                    "internalType": "uint256",
                    "name": "num",
                    "type": "uint256"
                }
            ],
            "name": "store",
            "outputs": [],
            "stateMutability": "nonpayable",
            "type": "function"
        }
    ],
    "is_changed_bytecode": false,
    "is_partially_verified": true,
    "constructor_args": "0x00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000003000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000003"
}

@tom2drum tom2drum added bug Something isn't working and removed triage Issues and PRs that are needed triage labels Nov 14, 2024
@tom2drum tom2drum self-assigned this Nov 18, 2024
tom2drum added a commit that referenced this issue Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants