JUnit don't report when segfault occure

[bleargh45]

Migrated from rt.cpan.org #91219 (status was 'open')

Requestors:

• [email protected]

From [email protected] on 2013-12-06 16:24:53
:

cat segfault2.t
#!/usr/bin/perl

use strict;
use warnings;
use POSIX;

$|=1;
print "1..1\nok\n";
kill POSIX::SIGSEGV => $$;

Let's try test it

prove --formatter TAP::Formatter::JUnit ./segfault2.t

So we don't see a problem and think that all right.
I've pathed TAP/Formatter/JUnit/Session.pm
181a182,183

} elsif ( my $wait = $parser->wait ) {
    $die_msg = "Non-zero wait status: $wait";

after apply this patch, when we run test

prove --formatter TAP::Formatter::JUnit ./segfault2.t

[bleargh45]

From [email protected] on 2017-09-05 13:51:59
:

We ran into this bug, which still affects version 0.11 of TAP::Formatter::JUnit.

As the patch indicates, the problem is that the close_test method only checks $parser->exit(), which happens to return 0 for processes that don't have an exit status because they were killed by a signal. It should test $parser->wait() in the first place.

Or maybe check $parser->has_problems as a fallback.

--
Lukas Mai / Software Developer
Jochen Schweizer Technology Solutions GmbH, München
Amtsgericht München, HRB 203111
Geschäftsführer: Florian Herschke, Saad Daoud; Prokurist: Herbert Leitz