Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get invoice feature #19

Open
Dolu89 opened this issue Aug 16, 2022 · 3 comments · May be fixed by #25
Open

Add get invoice feature #19

Dolu89 opened this issue Aug 16, 2022 · 3 comments · May be fixed by #25
Assignees
@Dolu89
Labels
enhancement New feature or request

Comments

@Dolu89
Copy link
Member

Dolu89 commented Aug 16, 2022

No description provided.

@Dolu89 Dolu89 added the enhancement New feature or request label Aug 16, 2022
@Dolu89 Dolu89 self-assigned this Aug 16, 2022
@louneskmt
Copy link
Member

louneskmt commented Aug 16, 2022 •
edited
Loading

We should change "get" to "decode" as "get" might mean we are querying an existing invoice in the node database.

Also, FYI the decodepay method isn't available yet via gRPC for Core Lightning (v0.11.2 and master). For now, we can just return a custom Unimplemented or equivalent error.

@louneskmt louneskmt mentioned this issue Aug 17, 2022
Open
3 tasks
@Dolu89 Dolu89 changed the title Add get invoice Add get invoice feature Aug 17, 2022
@Dolu89
Copy link
Member Author

Dolu89 commented Aug 17, 2022

We should change "get" to "decode" as "get" might mean we are querying an existing invoice in the node database.

Also, FYI the decodepay method isn't available yet via gRPC for Core Lightning (v0.11.2 and master). For now, we can just return a custom Unimplemented or equivalent error.

I think we need both get and decode.

  • get for querying an existing invoice from the node => can get settled information
  • decode for decoding any invoice => can't get settled information

@louneskmt
Copy link
Member

louneskmt commented Aug 17, 2022 •
edited
Loading

Gotcha, opened #22 to track the decode feature.

@Dolu89 Dolu89 linked a pull request Aug 17, 2022 that will close this issue
feat: add get_invoice feature #25
Open
3 tasks
@louneskmt louneskmt mentioned this issue Sep 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dolu89 Dolu89

Labels
enhancement New feature or request
Projects
UNA
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add get_invoice feature Dolu89/una
2 participants
@Dolu89 @louneskmt