Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore right/end padding of last child in a line #14

Open
RyanRamchandar opened this issue Mar 9, 2015 · 8 comments
Open

Ignore right/end padding of last child in a line #14

RyanRamchandar opened this issue Mar 9, 2015 · 8 comments
Assignees
Labels
Milestone

Comments

@RyanRamchandar
Copy link
Contributor

Ignoring the right/end padding of the last child can allow more children to fit on a line.

A workaround for now is to reduce the right/end padding of the FlowLayout to offset the child right/end padding.

device-2015-03-09-165230

@blazsolar blazsolar self-assigned this Mar 10, 2015
@blazsolar blazsolar added the bug label Mar 10, 2015
@RyanRamchandar
Copy link
Contributor Author

Similarly, the bottom padding of the children in the last row can be ignored.

@blazsolar
Copy link
Owner

I'll try to look into this in next couple of week. Thanks for raising the issue.

@riyase
Copy link

riyase commented May 20, 2015

is that a good idea?.. if we remove right margin of the last child in row (6th one) and add one more child(7th one) right to that .. there will not be any margin between 6th and 7th. now the last child is 7th and there should be a margin between 6th and 7th according to the above design.. but there is no space..

@blazsolar
Copy link
Owner

So what should happen is that we should try to add 7th item to the row without margin. If it fits in we leave it there and we leave margin of 6th item in. If 7th item without margin does not fit in the row it should be added to next row as 1st item with margin included.

@RyanRamchandar
Copy link
Contributor Author

@blazsolar Yes this is correct.

@vaughandroid
Copy link

I would suggest that the children's margins ought to be respected. It's generally a bad idea for a layout manager to remove/ignore properties of the views it is managing.
What's really wanted here are a couple of properties on the FlowLayout - horizontal spacing & vertical spacing.

@RyanRamchandar
Copy link
Contributor Author

@vaughandroid yes I agree with this approach.

@blazsolar blazsolar added this to the 1.0 milestone Sep 8, 2015
@RyanRamchandar
Copy link
Contributor Author

@blazsolar any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants