-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore right/end padding of last child in a line #14
Comments
Similarly, the bottom padding of the children in the last row can be ignored. |
I'll try to look into this in next couple of week. Thanks for raising the issue. |
is that a good idea?.. if we remove right margin of the last child in row (6th one) and add one more child(7th one) right to that .. there will not be any margin between 6th and 7th. now the last child is 7th and there should be a margin between 6th and 7th according to the above design.. but there is no space.. |
So what should happen is that we should try to add 7th item to the row without margin. If it fits in we leave it there and we leave margin of 6th item in. If 7th item without margin does not fit in the row it should be added to next row as 1st item with margin included. |
@blazsolar Yes this is correct. |
I would suggest that the children's margins ought to be respected. It's generally a bad idea for a layout manager to remove/ignore properties of the views it is managing. |
@vaughandroid yes I agree with this approach. |
@blazsolar any updates on this? |
Ignoring the right/end padding of the last child can allow more children to fit on a line.
A workaround for now is to reduce the right/end padding of the FlowLayout to offset the child right/end padding.
The text was updated successfully, but these errors were encountered: