Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google Cloud logger dependency? #325

Open
bneigher opened this issue Sep 21, 2023 · 3 comments
Open

Remove Google Cloud logger dependency? #325

bneigher opened this issue Sep 21, 2023 · 3 comments

Comments

@bneigher
Copy link
Contributor

I'm wondering if having the Google Cloud logger as a dependency is really neccessary? It's adding a few Mb to my lambda bundle which is a bit large for a lightweight slack nestjs wrapper. Is it possible to remove that with the default nestjs logger? I feel like that would make this a bit more nestjs friendly.

@simenandre
Copy link
Member

Yes, I think that is doable.

We probably rid ourselves of some of the types used there or copy them over. The dependency can be moved as a peer dependency or potentially dropped in favour of writing it ourselves. Especially considering that we are not using any of the Google Cloud-logger request bits (meaning where we send logs directly to Google Cloud Logger). We're just using the form and types.

Are you up for creating a PR on this?

@bneigher
Copy link
Contributor Author

I was unable to run the tests unfortunately... node-fetch / esm vs commonjs issues? But here we go!

#326 @simenandre

@bneigher
Copy link
Contributor Author

nvmd, fixed tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants