Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postMessage returns void instead of response #261

Open
ithan opened this issue Oct 26, 2022 · 1 comment
Open

postMessage returns void instead of response #261

ithan opened this issue Oct 26, 2022 · 1 comment

Comments

@ithan
Copy link

ithan commented Oct 26, 2022

The postMessage function from https://github.com/bjerkio/nestjs-slack/blob/main/src/slack.service.ts#L109 should return the API response to work with it, for things like sending messages to a thread instead of void.

@simenandre
Copy link
Member

I totally agree!

You might also notice that we have multiple ways to send a message to Slack, which is why we are returning void today. It makes sense to return a type that maybe have an API response. Does that make sense for your use case too?

On this topic, we might want to think about how we can create threads on all our sending methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants