Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making nestjs-slack a pure ESM package #218

Open
simenandre opened this issue Jul 13, 2022 · 2 comments
Open

Making nestjs-slack a pure ESM package #218

simenandre opened this issue Jul 13, 2022 · 2 comments

Comments

@simenandre
Copy link
Member

While there is soon to be a breaking change (moving this package to v2), I think it's time to discuss when to move to pure ESM.

I know there are a lot of teams that still use CommonJS, and from what I can understand the nest community is slowly moving that way. This means we can start planning for a new major release (v3).

Feel free to add feedback on this, and maybe share a timeline for when you are going ESM! I think we will keep maintaining v2 for quite some time, regardless of when v3 comes out.

Thanks ❤️

@simenandre simenandre pinned this issue Jul 13, 2022
@simenandre
Copy link
Member Author

node-fetch just went pure ESM in v3. IMHO, that pushes us forward towards ESM.

@simenandre
Copy link
Member Author

Let's make the next major ESM, for sure.

But I also think we can easily support, at least for a while, a legacy version that is running CommonJS. For example, by using a separate branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant