Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md WebSocket API needs update #581

Open
plexorama opened this issue May 9, 2018 · 0 comments
Open

README.md WebSocket API needs update #581

plexorama opened this issue May 9, 2018 · 0 comments

Comments

@plexorama
Copy link

in the WebSocket API section of the README.md, there is the following statement:

block: new block received from network. This event is published in the inv room. Data will be a app/models/Block object. Sample output:

{
  "hash":"000000004a3d187c430cd6a5e988aca3b19e1f1d1727a50dead6c8ac26899b96",
  "time":1389789343,
  ...
}

But the the data/block info received is not a JSON object as stated in the README.md, but a plan string. Here is what I got from io.socket Java debugging output:

socket received: type 'message', data '2["block","000000000000000000075609555b5e588082f37aca1cb0d2cf5419a4c033cd28"]'

In fact, only the block id is passed to the listener as a string:

"000000000000000000075609555b5e588082f37aca1cb0d2cf5419a4c033cd28"

Would you mind updating the README.md to reflect the actual API output?

I've tested this on test-insight.bitpay.com and insight.bitpay.com. Both with same results.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant