Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockclock UI bugs #393

Open
1 task done
stackingsaunter opened this issue Apr 1, 2024 · 6 comments
Open
1 task done

Blockclock UI bugs #393

stackingsaunter opened this issue Apr 1, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@stackingsaunter
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behaviour

CleanShot 2024-04-01 at 17 48 34@2x

I also had similar bug with placing of bitcoin logo on Android, Samsung S9

Expected behaviour

  1. Clock should be centered
  2. Bitcoin logo should be centered between % and top of the circle
  3. Clock icon in the nav bar should be visable

Steps to reproduce

Run compiled binary, go to blockclock screen

Relevant log output

debug.log

How did you obtain Bitcoin Core

Pre-built binaries

What version of Bitcoin Core are you using?

v25.99.0-dfad9947e903-dirty

Operating system and version

MacOS Sonoma 14.3.1

Machine specifications

No response

@pablomartin4btc
Copy link
Contributor

  1. Clock should be centered

At the time of my last review #389 that was fixed, at least for Ubuntu.

  1. Bitcoin logo should be centered between % and top of the circle

cc @johnny9

  1. Clock icon in the nav bar should be visable

I think that was going to be done on a separate PR as the #389's author explained.

@GBKS
Copy link
Contributor

GBKS commented Apr 9, 2024

Here's an overlay of the screenshot above and the design to illustrate the difference (size and position of the logo/icon).

image

Bitcoin logo should be centered between % and top of the circle

Note that this is not accurate. It is not centered. The spacing measurements can be taken from Figma here.

@jarolrod
Copy link
Member

Leaving this open as while we don't have the original issue, we still are not adherent to the block clock design (in several ways)

@jarolrod jarolrod added the good first issue Good for newcomers label Sep 25, 2024
@ciegovolador
Copy link

ciegovolador commented Nov 25, 2024

Hello I am new here
I would like to take just "Clock icon in the nav bar should be visable" as my first contribution
Should I open another issue for that?
Also what icon should I use?
I didn't found the icon in figma
https://www.figma.com/design/ek8w3n3upbluw5UL2lGhRx/Bitcoin-Core-App-Design
so my options are the clock icon from https://bitcoinicons.com/
or blocktime-dark / blocktime-light as those are the closest ones to the case study screenshots
https://bitcoin.design/assets/images/guide/case-studies/bitcoin-core-app/activity.png
Any advice will be really appreciated

@ciegovolador
Copy link

I made PR 15 days ago, looking for feedback on how to implent the component
Where should I ask for this?
also I need some icons from figma not included in the icons repository
Should I open an issue there?

@GBKS
Copy link
Contributor

GBKS commented Dec 10, 2024

@ciegovolador thanks for contributing. It's best to keep the conversation in the comment on that PR. If you'd like to chat about your changes, you can also post in the Bitcoin Design Discord, where we have a dedicated channel for this project (#bitcoin-core-app).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants