Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Refactor/world model capsule #301

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

jaagut
Copy link
Member

@jaagut jaagut commented Mar 29, 2023

Proposed changes

  • Rename many functions and variables regarding ball handling
  • Fix a lot of typos
  • Simplify get_best_ball
  • Fix forget_ball
  • ...

Related issues

#300
#297

Necessary checks

  • Update package version
  • Run catkin build
  • Write documentation
  • Create issues for future work
  • Test on your machine
  • Test on the robot
  • Put the PR on our Project board

Needs a lot of testing!

@jaagut jaagut self-assigned this Mar 29, 2023
@jaagut jaagut requested review from Flova, val-ba and timonegk March 29, 2023 14:48
@jaagut jaagut requested a review from val-ba April 24, 2023 14:16
@@ -49,3 +51,4 @@ def __init__(self, node: Node):
self.head_capsule = HeadCapsule(self)
self.world_model = WorldModelCapsule(self)
self.costmap = CostmapCapsule(self)
self.team_data = TeamDataCapsule(node)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this capsule added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been added, such that the head behavior can also look at the teammate ball directly. This is a behavior change and needs testing. If we don't want to do this, we can simply remove this line.

@Flova
Copy link
Member

Flova commented May 24, 2023

This PR is still a draft and needs extensive testing imo..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants